Reply To: [Bug] ReflectionsTools.cs

[psykaw]

Hey,

I don’t understand because if you found a type due to fallbackNoNamespace you don’t use the typeFullName which is bad. You have to cache it to not lookup twice or more for the next time you have the same typeFullName. So the best solution is to do this:

1 2 3 4 5 6 7 8 9

if (fallbackNoNamespace){ //get type regardless namespace type = TryResolveWithoutNamespace(typeFullName, fallbackAssignable); if (type != null){ //we store the found type's.FullName in the cache (instead of provided name), so that other types dont fail. typeMap[typeFullName] = type; return typeMap[type.FullName] = type; } }

PS: I edited my NodeCanvas version to avoid resolution type by attribute(DeserializeFromAttribute) or without namespace. It causes a huge CPU spike when I instanciate a blackboard at runtime. Could it be resolved at serialization or something like that but not at runtime?
And for ReflectionTools::GetDirectType() it could be resolved quickly if you concat assembly name of the type at the end separated with a comma. Ex: Type.GetType(“UnityEditor.ProfilerWindow,UnityEditor.dll”).