A 1.6 bug

[lijingsama]

This task work well in old version. But in 1.6, it’s OnExecute method be called infinity.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47

using UnityEngine; using NodeCanvas.Variables;   namespace NodeCanvas.Actions { [Category("NCAction")] [AgentType(typeof(Transform))] public class PlayCameraPathAnimation : ActionTask {   public bool reverse; public bool waitForFinish = true; public bool alwaysBeginAtStart; // private bool isCameraAnimationFinished = false;   protected override string info { get {return "Play '" + (agent? agent.name : "NULL") + "'";} }   protected override void OnExecute() { CameraPathAnimator cpa = agent.GetComponent<CameraPathAnimator> ();   cpa.animationMode = reverse ? CameraPathAnimator.animationModes.reverse : CameraPathAnimator.animationModes.once;   if (alwaysBeginAtStart) { cpa.Seek(0); }   cpa.AnimationFinishedEvent += OnAnimationFinished; if (cpa == null) { EndAction(false); } cpa.Play (); if (!waitForFinish) EndAction(); }   private void OnAnimationFinished() { EndAction (); } } }

[lijingsama]

The grahp

[lijingsama]

I sure OnAnimationFinished has been called

[lijingsama]

I fixed it now.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61

using UnityEngine; using NodeCanvas.Variables;   namespace NodeCanvas.Actions { [Category("NCAction")] [AgentType(typeof(Transform))] public class PlayCameraPathAnimation : ActionTask {   public bool reverse; public bool waitForFinish = true; public bool alwaysBeginAtStart;   private bool isCameraAnimationFinished = false;   protected override string info { get {return "Play '" + (agent? agent.name : "NULL") + "'";} }   protected override void OnExecute() { CameraPathAnimator cpa = agent.GetComponent<CameraPathAnimator> (); isCameraAnimationFinished = false;   cpa.animationMode = reverse ? CameraPathAnimator.animationModes.reverse : CameraPathAnimator.animationModes.once;   if (alwaysBeginAtStart) { cpa.Seek(0); }   cpa.AnimationFinishedEvent += OnAnimationFinished; if (cpa == null) { EndAction(false); } cpa.Play (); }   protected override void OnUpdate() { if (!waitForFinish) { EndAction (); } else if (isCameraAnimationFinished) { EndAction (); } }   private void OnAnimationFinished() { CameraPathAnimator cpa = agent.GetComponent<CameraPathAnimator> (); cpa.AnimationFinishedEvent -= OnAnimationFinished; isCameraAnimationFinished = true; } } }

[lijingsama]

I think the documentation should be refresh for 1.6 version.

I saw, too many problem like this is waiting for me.

[lijingsama]

BTW, the Wait Until Finish property of Graph Owner Control is very helpful

[Gavalakis]

Hello,

Indeed, the EndAction needs to be called within OnExecute or OnUpdate for now, like you figured out.
I know this is not as convenient as calling it anywhere you like, like before and will probably find a way to do that as well.

All these changes lately have been made to gain a lot of performance speed and it’s very hard to keep everything the same due to the core changes made.

I will definetely update the documentation for 1.6 as soon as there are no more issues due to the changes in 1.6.
Please let me know if you find anything at all and I will fix it immediately.

Thanks a lot!

Join us on Discord: https://discord.gg/97q2Rjh

[Tyler Kirk]

The underlying change does perpetuate the usage of bool switches and is difficult to work around. The technique we used to work with this is similar to the implementation above, but instead, we utilized external bools, and unset them after leaving the action. This seemed to be useful because the graph will display additional debug information.

One of the other engineers however, was pretty upset by the change because it defied logic. (The part where is loops around into itself is indeed strange.) But we managed to figure it out.

Glad to see an active community.

Thanks the very promising plugin, we can’t wait to see what’s next!

Best,
Tyler

[Gavalakis]

Hello Tyler,

I definetely agree with your other upset engineer. It’s not that convenient as it was prior to 1.6, but it was a sacrifice I opt to make for performance.
Probably that performance gain is less important than the convenience of calling EndAction anywhere.
So, because I also believe that convenience and expression are more important than performance in most cases, I will make sure that EndAction can be called anywhere like it was before for the next point version, hopefully keeping most performance gained due to the change.

Thanks for the elaboration on the subject!
Best regards,
Gavalakis

Join us on Discord: https://discord.gg/97q2Rjh

[Author]

Posts