Array Member in Custom Actions Issue

[mansonet]

Hi, we are having some issues with array type members of custom actions, NC tries to handle it as IList which is not right.
Class definition:

1 2 3

private string[]      stringArray;

We are using v1.5.2 and the error is:

IndexOutOfRangeException: Array index is out of range.
NodeCanvas.Variables.BBVariable.SetBBFields (NodeCanvas.Blackboard bb, System.Object o) (at Assets/NodeCanvas/Core/Blackboard/BBVariables.cs:46)
NodeCanvas.Task.UpdateBBFields (NodeCanvas.Blackboard bb) (at Assets/NodeCanvas/Core/Tasks/Task.cs:317)
NodeCanvas.Task.SetOwnerSystem (ITaskSystem newOwnerSystem) (at Assets/NodeCanvas/Core/Tasks/Task.cs:69)
NodeCanvas.Graph.SendTaskOwnerDefaults () (at Assets/NodeCanvas/Core/Graph/Graph.cs:153)
NodeCanvas.Graph.set_agent (UnityEngine.Component value) (at Assets/NodeCanvas/Core/Graph/Graph.cs:95)
NodeCanvas.Graph.StartGraph (UnityEngine.Component agent, NodeCanvas.Blackboard blackboard, System.Action callback) (at Assets/NodeCanvas/Core/Graph/Graph.cs:259)
NodeCanvas.Graph.StartGraph (UnityEngine.Component agent, NodeCanvas.Blackboard blackboard) (at Assets/NodeCanvas/Core/Graph/Graph.cs:231)
NodeCanvas.GraphOwner.StartBehaviour () (at Assets/NodeCanvas/Core/Graph/GraphOwner.cs:77)
NodeCanvas.GraphOwner.OnEnable () (at Assets/NodeCanvas/Core/Graph/GraphOwner.cs:195)

We bypass this error adding a validation in BBVariables.cs changing this:

1 2 3 4 5 6 7 8 9 10

///Set the blackboard provided for all BBVariable fields on the object provided public static void SetBBFields(Blackboard bb, object o){       CheckNullBBFields(o);       foreach (FieldInfo field in o.GetType().NCGetFields()){           if (typeof(IList).NCIsAssignableFrom(field.FieldType)){

into this:

1 2 3 4 5 6 7 8 9 10

///Set the blackboard provided for all BBVariable fields on the object provided public static void SetBBFields(Blackboard bb, object o){       CheckNullBBFields(o);       foreach (FieldInfo field in o.GetType().NCGetFields()){           if (!field.FieldType.IsArray && typeof(IList).NCIsAssignableFrom(field.FieldType)){

I’m not really familiar with FieldInfo class, so i’m not 100% sure if this is the right solution, for now it fixed our issues.

[Gavalakis]

Hey,

Thanks for bug report. Will fix that for next verion.
Cheers!

Join us on Discord: https://discord.gg/97q2Rjh

[Author]

Posts