Dictionary usage pattern

[bcristian]

Hello
Found the following pattern of checking if a key exists in a dictionary and then checking the value:
if (dict.ContainKey(key) && dict[key] == value)
this does 2 lookups, and can be optimized to do just one:

1 2	var dictValue; if (dict.TryGetValue(key, out dictValue) && dictValue == value)

I’ve encountered it PlayAnimationSimple and PlayAnimationAdvanced.
Yes, I know the performamce impact in this case is minor to irrelevant 🙂

[Gavalakis]

Hey,

Even if there is no apparent performance impact, it’s still good to keep with good practices.
I’ve just changed the code there, which hopefully isn’t similar anywhere else.
(PlayAnimationAdvanced does not have any dictionary usage by the way)

Thank you.

Join us on Discord: https://discord.gg/97q2Rjh

[Author]

Posts