Error when moving reflected method from class to a base class

[Async0x42]

I have two classes for example. NPC which inherits from BaseMobile.

I have a StopMoving function in NPC, which is reflected in a behaviour tree, but then I move it to BaseMobile (or vice versa).

When loading the behaviour tree, I get the following error spammed and almost locks up Unity completely. I’m not sure if it’s just a bug that’s allowing it to do that, but if not, perhaps some kind of catch so that it shows Empty Method similar to if the method was removed (or re-does the reflection, since the method was reflected via NPC and is still available after moving to BaseMobile since NPC inherits from it)

Hope that made sense… I’m not great at explaining, but thanks for your work on NodeCanvas, I’ve tried a few and this is definitely my best purchase on the asset store!

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33

(22:08:41.8422) Exception: NullReferenceException: Object reference not set to an instance of an object   StackTrace: ParadoxNotion: ReflectionTools.RTGetMethod()     NodeCanvas/Framework/_ParadoxNotion(shared)/Runtime/Other/ReflectionTools.cs: line 285 ParadoxNotion.Serialization: SerializedMethodInfo.Get()     NodeCanvas/Framework/_ParadoxNotion(shared)/Runtime/Serialization/SerializedMethodInfo.cs: line 34 NodeCanvas.Framework.Internal: ReflectedWrapper.GetMethod()     NodeCanvas/Framework/Runtime/ReflectionWrappers/ReflectedMethodWrapper.cs: line 28 NodeCanvas.Tasks.Actions: ExecuteFunction.get_targetMethod()     NodeCanvas/Tasks/Actions/ScriptControl/ExecuteFunction.cs: line 23 NodeCanvas.Tasks.Actions: ExecuteFunction.get_info()     NodeCanvas/Tasks/Actions/ScriptControl/ExecuteFunction.cs: line 33 NodeCanvas.Framework: Task.get_summaryInfo()     NodeCanvas/Framework/Runtime/Tasks/Task.cs: line 226 NodeCanvas.Framework: ActionList.get_info()     NodeCanvas/Framework/Runtime/Tasks/ActionList.cs: line 42 NodeCanvas.Framework: Task.get_summaryInfo()     NodeCanvas/Framework/Runtime/Tasks/Task.cs: line 226 NodeCanvas.Framework: Node.ShowNodeContents()     NodeCanvas/Framework/Design/PartialEditor/EDITOR_Node.cs: line 384 NodeCanvas.Framework: Node.NodeWindowGUI()     NodeCanvas/Framework/Design/PartialEditor/EDITOR_Node.cs: line 250 UnityEngine.GUILayout+LayoutedWindow.DoWindow()     C:/buildslave/unity/build/artifacts/generated/common/runtime/GUILayout.gen.cs: line 413 UnityEngine.GUI.CallWindowDelegate()     C:/buildslave/unity/build/artifacts/generated/common/runtime/GUI.gen.cs: line 1458 UnityEditor.EditorWindow.EndWindows()     None: line 0 NodeCanvas.Editor: GraphEditor.OnGUI()     NodeCanvas/Framework/Design/Editor/Windows/GraphEditor.cs: line 279

[Gavalakis]

Hello and thanks!

I am glad you like NC 🙂

I just tried reproducing this and didnt throw errors, but I am using a more latest version than 2.2 which is on the asset store, which I’m going to submit soon.

Would you mind opening up SerializedMethodInfo.cs and add this null check there under method “Get”?

1 2 3 4 5 6 7

if (_method == null && !string.IsNullOrEmpty(_baseInfo)){ var type = ReflectionTools.GetType(_baseInfo.Split('|')[0]); if (type == null){ return null; }

I could also send you the latest version if you like to your email.

Thanks!

Join us on Discord: https://discord.gg/97q2Rjh

[Async0x42]

I applied that change and I can’t seem to reproduce the error, plus the method still displays even after moving it between class / sub-class.

Unless I did something that I don’t remember which caused it, the fix seems to work, thanks! Looking forward to your next version!

[Author]

Posts