Inheritance and binding

[jschanhals]

I am finding that binding of properties and methods is not doing what I would have thought when using inherited classes with virtual/overridden methods/properties. Given the classes below:

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46

using UnityEngine;   namespace Assets.NodeCanvasTests {     public class TestBase1 : MonoBehaviour     {         public virtual string myName         {             get             {                 return "TestBase1";             }         }           public string className         {             get             {                 return this.GetType().FullName;             }         }     } } namespace Assets.NodeCanvasTests {     public class TestChild1 : TestBase1     {         public override string myName         {             get             {                 return "TestChild1";             }         }           public string myRealName         {             get             {                 return myName;             }         }     } }

When binding to TestChild1.myName and using a LogText (or even a LogVariable) action node, the value ‘TestBase1’ is logged rather than the expected ‘TestChild1’. Similar behavior when calling a method – the base’s method is called and not the overridden one.

Is there something I need to do to get the overridden method/property called? Or is this a problem with NodeCanvas implementation?

Attached is a sample scene that demonstrates this issue.

Jeff

Attachments:

You must be logged in to view attached files.

[Gavalakis]

Hello and sorry for the late reply due to summer vacation.

This is a unintended behavior that I wasn’t aware of. Thanks for reporting this problem.
To fix this quickly, please open up ReflectionTools.cs file, fine and replace method RTCreateDelegate with the following code:

1 2 3 4 5 6 7 8 9 10 11 12

public static Delegate RTCreateDelegate(this MethodInfo method, Type type, object instance){ if (instance != null){ method = instance.GetType().RTGetMethod(method.Name, method.GetParameters().Select(p => p.ParameterType).ToArray() ); } #if NETFX_CORE return method.CreateDelegate(type, instance); #else             return Delegate.CreateDelegate(type, instance, method); #endif         }

The difference here is that if re-fetch the method type from the true type of the instance if any before creating the delegate and as such, the delegate will correctly call the child method/property from there-on.

Please let me know if making this change also works for you.

Thanks again for the error report.

Join us on Discord: https://discord.gg/97q2Rjh

[jschanhals]

Thanks for the updated code. For the test scene that I had attached, this fixes the issue. I will validate it further in our main project.

[Gavalakis]

Thanks for the follow up.
If you find any problems with this, please let me know.

Join us on Discord: https://discord.gg/97q2Rjh

[Author]

Posts