[NodeCanvas] Small memory allocation when changing the active subgraph

[leanon00]

Hello! Hope this can be fixed.

I found a memory allocation when changing the active subgraph in a very common usage pattern
this allocates memory because of the lambda variables scope capture.

Attached the stack trace from a deep profiling in unity where it allocates 160 B for every sub tree change.

Attachments:

You must be logged in to view attached files.

[Gavalakis]

Hello!

You are right. I plan to do another review of everything soon (something I typically do once in a while to refactor things), and will fix this 🙂

Thank you.

Join us on Discord: https://discord.gg/97q2Rjh

[viktor]

Hello!
Could you clarify, is that problem resolved in new versions?

[Gavalakis]

Hello! It is not exactly a problem but rather a small allocation when using subgraphs specifically. I do however want to fix this so that it does not allocate at all in this case. Thank you.

Join us on Discord: https://discord.gg/97q2Rjh

[poisonousjohn]

Hi there, though the allocation is small, it accumulates over the time leading to GC triggering. In our game we have requirement to not allocate more than 300B per frame (unity recommendation), which is not possible to satisfy because of the NodeCanvas

We would appreciate if you fix it.

[Gavalakis]

Hello there. If it is a showstopper for you now, I can send you a quickfix to your email. If so please send me an email to support_AT_paradoxnotion.com.

Best regards.

Join us on Discord: https://discord.gg/97q2Rjh

[Author]

Posts