Prefered Types Editor Not Saving Certain Types

[Async0x42]

When I went to remove a component, I added the type to the Preferred Types Editor, it shows, however afterwards it doesn’t show in the Remove Component menu. After reopening the Preferred Types Editor, it’s not in the list anymore.

I can reproduce it as simple as:
1) Add CC_Pixelate (from Colorful asset) to Preferred Types -> Displays on the bottom of the list
2) Close Preferred Types Window
3) Re-open Preferred Types -> No CC_Pixelate in the list

It is saved properly the first time, however, as I stepped through it with the debugger and it was there until the very end, as well as:
1) Add CC_Pixelate
2) Add CC_Pixelate a second time -> Type already in list

In the windows registry however…
CC_Pixelate DOES show up. So it is saving, but it’s not loading for some reason (?)

Note: Apparently all of the CC_***’s I tried, save but can’t be loaded in the list. All of my own components are able to be saved and displayed, but Colorful ones, for some reason, aren’t.

And while on the topic, “Prefered” should be “Preferred” (Didn’t realize until Chrome flagged the word for me and then I looked at the dictionary)

[Gavalakis]

Hey,

Yeah. There is some filtering done to the types added in the list. Basicaly if a type has no public methods or properties, it is filtered out from showing in the blackboard, but I’ve also noticed some other bug as well in the types editor window. It’s all fixed now, but here are some things you can do until the next release:

1) Open up PreferedTypesEditorWindow.cs and change OnEnable to:

1 2 3 4 5 6

void OnEnable(){ title = "Preferred Types"; typeList = UserTypePrefs.GetPreferedTypesList(typeof(object), true); }

This fixes the Editor window list from reseting.

2) Open up UserTypePrefs.cs and at line #103, change the whole ‘if’ check to:

1 2 3 4 5 6 7 8 9 10 11 12 13

if (!includeFunctionalTypes){ foreach (var t in types.ToArray()){ if ( !t.IsEnum && t.GetMethods(BindingFlags.Instance | BindingFlags.Public | BindingFlags.DeclaredOnly).Length == 0 && t.GetFields(BindingFlags.Instance | BindingFlags.Public | BindingFlags.DeclaredOnly).Length == 0 ) { types.Remove(t); } } }

This fixes the filtering done to also check for fields (instead of only methods/properties)

Cheers!

Join us on Discord: https://discord.gg/97q2Rjh

[Async0x42]

Thanks, works perfectly now!

[Author]

Posts