Small change request to support calling EndAction from OnExecute

[patrickl]

Hi,

I have some cases where I want to immediately exit a action from OnExecute however it can cause issues where the current state becomes null during the FSM OnGraphUpdate. I’ve manually patched this myself but I have to keep re-applying it when I upgrade. Would it be possible to add this in for the next update? My change is in bold:

protected override void OnGraphUpdate() {
…
//Update current state
currentState.Execute(agent, blackboard);

  //this can only happen if FSM stopped just now (from the above Execute)
  if ( currentState == null ) { Stop(false); return; }
}

 

I also had some obsolete API warnings when updating to latest version. I let Unity update the usages and everything seems fine but thought I would point it out. I’m on latest Unity 2021 LTS

Thanks
Patrick

[Gavalakis]

Hello there. What NodeCanvas version are you using please? I am asking because there actually is such a call there.

1 2 3 4 5 6 7 8 9 10 11 12

... //Update current state currentState.Execute(agent, blackboard); if ( onStateUpdate != null && currentState.status == Status.Running ) { onStateUpdate(currentState); }   //this can only happen if FSM stoped just now (from the above update) if ( currentState == null ) { Stop(false); return; } ...

Or do you mean this call being right after the currentState.Execute call?

Let me know. Thanks 🙂

Join us on Discord: https://discord.gg/97q2Rjh

[patrickl]

Yeah, after the currentState.Execute call. So it does the same check as it does after Update call.

[Gavalakis]

Alright, no problem. I will add that for the next version 🙂

Join us on Discord: https://discord.gg/97q2Rjh

[Author]

Posts